ADFA-5109: Remove unused Room deps from idetooltips by davidschachterADFA · Pull Request #1662 · appdevforall/CodeOnTheGo

davidschachterADFA · 2026-08-12T05:57:55Z

Summary

idetooltips's ToolTipManager reads documentation.db via raw SQLiteDatabase (ADR 0001, exception 1) — no source file in the module imports androidx.room. Removes the now-dead kapt(room.compiler) / room.ktx deps and the kotlin-kapt plugin they were the only user of.
Closes out the ADR 0001 follow-up item that flagged this; updates ADR 0001 and ARCHITECTURE.md's persistence-exceptions notes accordingly.

Test plan

:idetooltips:compileV8DebugKotlin — builds clean.
:app:compileV8DebugKotlin — builds clean (sanity-checks the dependency chain into idetooltips).
spotlessCheck passed via the pre-push hook.

🤖 Generated with Claude Code

ToolTipManager reads documentation.db via raw SQLiteDatabase, not Room (ADR 0001, exception 1) -- no source file in the module imports androidx.room. Drops the now-pointless kapt(room.compiler)/room.ktx deps and the kotlin-kapt plugin they were the only user of, and closes out the ADR 0001 follow-up that flagged this.

claude

Claude Code Review

This repository is configured for manual code reviews. Comment @claude review for a one-time review, or @claude review always to subscribe this PR to a review on every future push.

_{Tip: disable this comment in your organization's Code Review settings.}

coderabbitai · 2026-08-12T05:58:05Z

Warning

Review limit reached

@davidschachterADFA, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 40 minutes

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: bd61c402-4909-46dd-9b77-5cc28f0f5e2d

📥 Commits

Reviewing files that changed from the base of the PR and between c50ff5d and 57d8c77.

📒 Files selected for processing (2)

ARCHITECTURE.md
docs/adr/0001-prefer-room-for-persistence.md

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: b65cc31b-ce6a-43a2-98d8-89181901e558

📥 Commits

Reviewing files that changed from the base of the PR and between ffb63dd and c50ff5d.

📒 Files selected for processing (3)

ARCHITECTURE.md
docs/adr/0001-prefer-room-for-persistence.md
idetooltips/build.gradle.kts

💤 Files with no reviewable changes (1)

idetooltips/build.gradle.kts

📝 Walkthrough

Removed unused Room dependencies and the kotlin-kapt plugin from idetooltips.
Updated ARCHITECTURE.md and ADR 0001 to document the completed persistence-exception follow-up.
Validation passed: :idetooltips:compileV8DebugKotlin, :app:compileV8DebugKotlin, and spotlessCheck.
Risk: Low. The change removes unused declarations and does not alter public entities or runtime persistence behavior.

Walkthrough

The idetooltips module no longer uses Kotlin KAPT or Room dependencies. Architecture documentation now reflects this state and retains the existing autocomplete clarification.

Changes

Room dependency cleanup

Layer / File(s)	Summary
Remove Room build declarations `idetooltips/build.gradle.kts`	The module no longer applies `kotlin-kapt` or declares Room compiler and KTX dependencies.
Align persistence documentation `ARCHITECTURE.md`, `docs/adr/0001-prefer-room-for-persistence.md`	The documentation no longer requires removal of unused Room dependencies from `idetooltips`. The editor autocomplete clarification remains.

Estimated code review effort: 2 (Simple) | ~5 minutes

Possibly related PRs

appdevforall/CodeOnTheGo#1422: Removes the same unused Room and KAPT dependencies and updates related documentation.

Suggested reviewers: jomen-adfa

Poem

A bunny checked the build with care,
And found no Room code hiding there.
KAPT hopped away,
Docs matched the day,
While autocomplete stayed in its lair.

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly identifies the main change: removing unused Room dependencies from the idetooltips module.
Description check	✅ Passed	The description accurately explains the dependency removal, raw SQLiteDatabase usage, documentation updates, and validation checks.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

📝 Generate docstrings

Create stacked PR
Commit on current branch

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch task/ADFA-5109-idetooltips-room-cleanup

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

…oltips-room-cleanup # Conflicts: # ARCHITECTURE.md

claude Bot reviewed Aug 12, 2026

View reviewed changes

appdevforall deleted a comment from coderabbitai Bot Aug 12, 2026

Daniel-ADFA approved these changes Aug 12, 2026

View reviewed changes

dara-abijo-adfa approved these changes Aug 12, 2026

View reviewed changes

davidschachterADFA added 2 commits August 12, 2026 15:27

Merge branch 'stage' into task/ADFA-5109-idetooltips-room-cleanup

d5f6a59

Merge remote-tracking branch 'origin/stage' into task/ADFA-5109-ideto…

57d8c77

…oltips-room-cleanup # Conflicts: # ARCHITECTURE.md

davidschachterADFA merged commit ca80514 into stage Aug 13, 2026
4 checks passed

davidschachterADFA deleted the task/ADFA-5109-idetooltips-room-cleanup branch August 13, 2026 19:36

Navigation Menu

Uh oh!

Uh oh!

ADFA-5109: Remove unused Room deps from idetooltips - #1662

ADFA-5109: Remove unused Room deps from idetooltips#1662
davidschachterADFA merged 3 commits into
stagefrom
task/ADFA-5109-idetooltips-room-cleanup

davidschachterADFA commented Aug 12, 2026

Uh oh!

claude Bot left a comment

Uh oh!

coderabbitai Bot commented Aug 12, 2026 •

edited

Loading

Review limit reached

Walkthrough

Changes

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Uh oh!

Conversation

davidschachterADFA commented Aug 12, 2026

Summary

Test plan

Uh oh!

claude Bot left a comment

Choose a reason for hiding this comment

Claude Code Review

Uh oh!

coderabbitai Bot commented Aug 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review limit reached

Walkthrough

Changes

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

coderabbitai Bot commented Aug 12, 2026 •

edited

Loading